hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2792) Create a better way to chain log cleaners
Date Thu, 29 Jul 2010 13:54:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893614#action_12893614

HBase Review Board commented on HBASE-2792:

Message from: "Chongxin Li" <lichongxin@zju.edu.cn>

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-07-29 06:51:56.166539)

Review request for hbase.


I've tested this path. This can be applied.


HBASE-2792: Create a better way to chain log cleaners

This addresses bug HBASE-2792.

Diffs (updated)

  src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java 3ca3611 
  src/main/java/org/apache/hadoop/hbase/master/LogsCleaner.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java 37b2c3c 
  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 9fb1cce 
  src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java eb859aa

  src/main/resources/hbase-default.xml e3a9669 
  src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/master/TestOldLogsCleaner.java a92e0da 

Diff: http://review.cloudera.org/r/372/diff


Unit test TestOldLogsCleaner passed.



> Create a better way to chain log cleaners
> -----------------------------------------
>                 Key: HBASE-2792
>                 URL: https://issues.apache.org/jira/browse/HBASE-2792
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Li Chongxin
>             Fix For: 0.90.0
> From Stack's review of HBASE-2223:
> {quote}
> Why this implementation have to know about other implementations?  Can't we do a chain
of decision classes? Any class can say no?  As soon as any decision class says no, we exit
the chain.... So in this case, first on the chain would be the ttl decision... then would
be this one... and third would be the snapshotting decision. You don't have to do the chain
as part of this patch but please open an issue to implement.
> {quote}

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message