hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2695) HMaster cleanup and refactor
Date Tue, 27 Jul 2010 16:40:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892843#action_12892843
] 

HBase Review Board commented on HBASE-2695:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/387/
-----------------------------------------------------------

(Updated 2010-07-27 09:31:00.269382)


Review request for hbase, stack and Karthik Ranganathan.


Changes
-------

Just attaching to HBASE-2695 to see if it makes it to the lists now


Summary
-------

This is the rest of the master cleanup and zookeeper cleanup.  Everything is moved over to
the new ZooKeeperWatcher, ZooKeeperListeners, ZKUtil/ZKAssign, etc...

There is a second page to the diff linked at the bottom with lots of good stuff, don't miss
it!

Now on to the good stuff!


This addresses bug HBASE-2695.
    http://issues.apache.org/jira/browse/HBASE-2695


Diffs
-----

  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/Abortable.java PRE-CREATION

  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/MiniZooKeeperCluster.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/ServerController.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/HBaseEventHandler.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/HBaseExecutorService.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionData.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionEventData.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 964617

  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ProcessRegionOpen.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/handler/MasterCloseRegionHandler.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/handler/MasterOpenRegionHandler.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/MasterAddressManager.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/RSZookeeperUpdater.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
964617 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperNodeTracker.java
PRE-CREATION 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
964617 
  branches/0.90_master_rewrite/src/main/resources/hbase-webapps/master/master.jsp 964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/TestMultiParallelPut.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
964617 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java
PRE-CREATION 

Diff: http://review.hbase.org/r/387/diff


Testing
-------

Most unit tests passing.  Still addressing remaining failures but most seem to be related
to the fact that I was running multiple tests and ZK clusters were stomping on each other.


Thanks,

Jonathan




> HMaster cleanup and refactor
> ----------------------------
>
>                 Key: HBASE-2695
>                 URL: https://issues.apache.org/jira/browse/HBASE-2695
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Jonathan Gray
>            Assignee: Karthik Ranganathan
>            Priority: Critical
>             Fix For: 0.90.0
>
>         Attachments: HBASE-2695-MasterStartupCleanup-v4.patch, HBASE-2695-part1-masterstatus.patch,
HBASE-2695-part2.1-masterstatus.patch
>
>
> Before doing the more significant changes to HMaster, it would benefit greatly from some
cleanup, commenting, and a bit of refactoring.
> One motivation is to nail down the initialization flow and comment each step.  Another
is to add a couple new classes to break up functionality into helpers to reduce HMaster size
(for example, pushing all filesystem operations into their own class).  And lastly to stop
the practice of passing around references to HMaster everywhere and instead pass along only
what is necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message