hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2794) ROWCOL bloom filter not used if multiple columns within same family are requested in a Get
Date Tue, 13 Jul 2010 02:54:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887638#action_12887638
] 

HBase Review Board commented on HBASE-2794:
-------------------------------------------

Message from: "Kris Jirapinyo" <kjirapinyo@attensity.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/296/
-----------------------------------------------------------

(Updated 2010-07-12 19:48:43.373418)


Review request for hbase.


Changes
-------

Implemented Kannan's suggestion, thereby removing keyList.


Summary
-------

HBASE-2794 Enable bloom filter checks for multiple columns in same column family


This addresses bug HBASE-2794.
    http://issues.apache.org/jira/browse/HBASE-2794


Diffs (updated)
-----

  /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 962748 
  /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 962748 

Diff: http://review.hbase.org/r/296/diff


Testing
-------

Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multiple times.  Ran and
passed all tests when building.


Thanks,

Kris




> ROWCOL bloom filter not used if multiple columns within same family are requested in
a Get
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-2794
>                 URL: https://issues.apache.org/jira/browse/HBASE-2794
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>
> Noticed the following snippet in StoreFile.java:Scanner:shouldSeek():
> {code}
>         switch(bloomFilterType) {
>           case ROW:
>             key = row;
>             break;
>           case ROWCOL:
>             if (columns.size() == 1) {
>               byte[] col = columns.first();
>               key = Bytes.add(row, col);
>               break;
>             }
>             //$FALL-THROUGH$
>           default:
>             return true;
>         }
> {code}
> If columns.size > 1, then we currently don't take advantage of the bloom filter. 
We should optimize this to check bloom for each of columns and if none of the columns are
present in the bloom avoid opening the file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message