hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2858) TestReplication.queueFailover fails half the time
Date Wed, 21 Jul 2010 18:39:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890817#action_12890817
] 

HBase Review Board commented on HBASE-2858:
-------------------------------------------

Message from: "Jean-Daniel Cryans" <jdcryans@apache.org>


bq.  On 2010-07-20 20:34:23, stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java,
line 221
bq.  > <http://review.hbase.org/r/349/diff/1/?file=2968#file2968line221>
bq.  >
bq.  >     Just remove this method altogether?

I was thinking of keeping it around in the interface for other uses... but currently there's
none. Deleting.


bq.  On 2010-07-20 20:34:23, stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java,
line 437
bq.  > <http://review.hbase.org/r/349/diff/1/?file=2968#file2968line437>
bq.  >
bq.  >     Is this right?  You are getting a reader here.  If file is not in expected location,
we fall into FNFE area.  These just seem to be testing existance, not getting a reader on
the new location if it exists.

If the queue was recovered, we're waiting for the master to finish splitting it to start reading
from it. Then it sleeps and retries.

If it's a normal queue, the location is updated. Then it sleeps and retries with the new location.
I guess it could get the reader right away.


- Jean-Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/349/#review435
-----------------------------------------------------------





> TestReplication.queueFailover fails half the time
> -------------------------------------------------
>
>                 Key: HBASE-2858
>                 URL: https://issues.apache.org/jira/browse/HBASE-2858
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.90.0
>
>
> TestReplication.queueFailover fails 50% of the time, it's because ZooKeeperWrapper.listZnodes
(introduced in HBASE-2694 and missed by HBASE-2735) doesn't use the Watcher it's passed so
sometimes ReplicationSource misses hlogs to replicate for the region server we kill. Also
it uncovered an issue (while I was fixing the first one) that RepSource ignores log files
too quickly when the master is a bit too slow to split logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message