hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2838) Replication metrics
Date Tue, 27 Jul 2010 00:29:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892565#action_12892565
] 

HBase Review Board commented on HBASE-2838:
-------------------------------------------

Message from: "Jean-Daniel Cryans" <jdcryans@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/381/
-----------------------------------------------------------

(Updated 2010-07-26 17:24:25.230486)


Review request for hbase.


Changes
-------

I split the replication metrics into two classes (one for source, one for sink). ReplicationSourceMetrics
will be instantiated as many times as there are sources, and they are named with the source
id. Took care of the other comments.


Summary
-------

Added the basic metrics, currently only accessible via hadoop metrics. Metrics maintenance
is done inline using ReplicationMetrics as a Singleton, wanted to get others opinion on that.

If we are to cut a 0.89 soon, at least this patch needs to go in IMO. 


This addresses bug HBASE-2838.
    http://issues.apache.org/jira/browse/HBASE-2838


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java 3eec1d7

  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 855cd6f

  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
0501048 
  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java
PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 28a6e51 

Diff: http://review.hbase.org/r/381/diff


Testing
-------

Unit tests


Thanks,

Jean-Daniel




> Replication metrics
> -------------------
>
>                 Key: HBASE-2838
>                 URL: https://issues.apache.org/jira/browse/HBASE-2838
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.90.0
>
>
> Replication needs to publish metrics about its performance:
>  - WALEdits read, filtered, sent to slave clusters, applied on slaves
>  - size of batches sent/received
>  - ms spent on reading, sending, applying edits
> This can be done using HadoopMetrics.
> Also we need to publish information not related to performance:
>  - size of each HLog queues
>  - age of the last replicated edit in each queue
>  - time of last successful replication
> These informations can hardly be graphed, but we still need to represent them somehow.
It has to be accessible by web UI, shell, and other tools in general. I don't feel strongly
about creating a new public method on HRS's interface, and I'm not sure publishing those in
ZooKeeper is a good idea either (why add another indirection?). Still wondering about a better
solution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message