hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2838) Replication metrics
Date Sun, 25 Jul 2010 04:13:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892070#action_12892070
] 

HBase Review Board commented on HBASE-2838:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/381/#review481
-----------------------------------------------------------


Looks good.  Few questions in below.


src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMetrics.java
<http://review.hbase.org/r/381/#comment1975>

    For sure these metrics show fine in ganglia?  Whats the prefix that they show up under?
 Is there one? (Looks like its hbase?  Thats OK i'd say.  Should prefix have replication in
it somewhere though?)



src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
<http://review.hbase.org/r/381/#comment1976>

    There will always be edits if we get this far?  (I'm wondering if ever a illegalAccessException
possible here)
    



src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
<http://review.hbase.org/r/381/#comment1977>

    Should this be 'notted'?  You want to count when row keys are not the same?



src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java
<http://review.hbase.org/r/381/#comment1978>

    Do you have to do this to make them show in JMX?  I didn't know.



src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
<http://review.hbase.org/r/381/#comment1979>

    What this?  Reenabling tests?


- stack





> Replication metrics
> -------------------
>
>                 Key: HBASE-2838
>                 URL: https://issues.apache.org/jira/browse/HBASE-2838
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.90.0
>
>
> Replication needs to publish metrics about its performance:
>  - WALEdits read, filtered, sent to slave clusters, applied on slaves
>  - size of batches sent/received
>  - ms spent on reading, sending, applying edits
> This can be done using HadoopMetrics.
> Also we need to publish information not related to performance:
>  - size of each HLog queues
>  - age of the last replicated edit in each queue
>  - time of last successful replication
> These informations can hardly be graphed, but we still need to represent them somehow.
It has to be accessible by web UI, shell, and other tools in general. I don't feel strongly
about creating a new public method on HRS's interface, and I'm not sure publishing those in
ZooKeeper is a good idea either (why add another indirection?). Still wondering about a better
solution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message