Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 57771 invoked from network); 1 Jun 2010 20:40:58 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 1 Jun 2010 20:40:58 -0000 Received: (qmail 67043 invoked by uid 500); 1 Jun 2010 20:40:58 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 67021 invoked by uid 500); 1 Jun 2010 20:40:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 67013 invoked by uid 99); 1 Jun 2010 20:40:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Jun 2010 20:40:58 +0000 X-ASF-Spam-Status: No, hits=-1486.8 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Jun 2010 20:40:58 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o51KebPP023752 for ; Tue, 1 Jun 2010 20:40:38 GMT Message-ID: <29335028.115091275424837357.JavaMail.jira@thor> Date: Tue, 1 Jun 2010 16:40:37 -0400 (EDT) From: "HBase Review Board (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-2635) ImmutableBytesWritable ignores offset in several cases MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874227#action_12874227 ] HBase Review Board commented on HBASE-2635: ------------------------------------------- Message from: "Todd Lipcon" ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/110/#review110 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java Before we were hashing the entire byte array, not just the section of bytes corresponding to this writable. So the hashcode could be different even if the sliced bytes were the same. See new unit test for hashcode. - Todd > ImmutableBytesWritable ignores offset in several cases > ------------------------------------------------------ > > Key: HBASE-2635 > URL: https://issues.apache.org/jira/browse/HBASE-2635 > Project: HBase > Issue Type: Bug > Affects Versions: 0.20.4, 0.21.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Attachments: hbase-2635.txt > > > HBASE-2378 improved ImmutableBytesWritable's comparator, but there's still a bug! We assume offset = 0, which makes the comparator function incorrectly when the ImmutableBytesWritable is a slice into a larger byte array. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.