Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 7233 invoked from network); 26 Jun 2010 07:52:17 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 26 Jun 2010 07:52:17 -0000 Received: (qmail 20041 invoked by uid 500); 26 Jun 2010 07:52:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 19993 invoked by uid 500); 26 Jun 2010 07:52:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 19985 invoked by uid 99); 26 Jun 2010 07:52:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Jun 2010 07:52:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Jun 2010 07:52:11 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5Q7poI1026917 for ; Sat, 26 Jun 2010 07:51:50 GMT Message-ID: <2269256.73411277538710158.JavaMail.jira@thor> Date: Sat, 26 Jun 2010 03:51:50 -0400 (EDT) From: "Kannan Muthukkaruppan (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-2794) ROWCOL bloom filter not used if multiple columns within same family are requested in a Get In-Reply-To: <25681835.73371277538410306.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882820#action_12882820 ] Kannan Muthukkaruppan commented on HBASE-2794: ---------------------------------------------- Perhaps a simple starter task for someone interested. > ROWCOL bloom filter not used if multiple columns within same family are requested in a Get > ------------------------------------------------------------------------------------------ > > Key: HBASE-2794 > URL: https://issues.apache.org/jira/browse/HBASE-2794 > Project: HBase > Issue Type: Improvement > Reporter: Kannan Muthukkaruppan > > Noticed the following snippet in StoreFile.java:Scanner:shouldSeek(): > {code} > switch(bloomFilterType) { > case ROW: > key = row; > break; > case ROWCOL: > if (columns.size() == 1) { > byte[] col = columns.first(); > key = Bytes.add(row, col); > break; > } > //$FALL-THROUGH$ > default: > return true; > } > {code} > If columns.size > 1, then we currently don't take advantage of the bloom filter. We should optimize this to check bloom for each of columns and if none of the columns are present in the bloom avoid opening the file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.