Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 53173 invoked from network); 8 Jun 2010 23:23:33 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Jun 2010 23:23:33 -0000 Received: (qmail 11173 invoked by uid 500); 8 Jun 2010 23:23:33 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11136 invoked by uid 500); 8 Jun 2010 23:23:33 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11127 invoked by uid 99); 8 Jun 2010 23:23:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jun 2010 23:23:33 +0000 X-ASF-Spam-Status: No, hits=-1507.1 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jun 2010 23:23:32 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o58NNCDa006657 for ; Tue, 8 Jun 2010 23:23:12 GMT Message-ID: <14330878.36261276039392304.JavaMail.jira@thor> Date: Tue, 8 Jun 2010 19:23:12 -0400 (EDT) From: "HBase Review Board (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-2691) LeaseStillHeldException totally ignored by RS, wrongly named In-Reply-To: <17617645.16251275957852232.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876859#action_12876859 ] HBase Review Board commented on HBASE-2691: ------------------------------------------- Message from: stack@duboce.net ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/164/#review160 ----------------------------------------------------------- Ship it! +1 after making the mostly javadoc changes suggested below. /trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Javadoc missing here... you need to explain the bit about how you can send a exception back to RS /trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java Fatten the message passed back to the regionserver. /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Not needed (after chatting w/ j-d) /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Same here /trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java Remove /trunk/src/test/java/org/apache/hadoop/hbase/TestYouAreDead.java These single test classes are killing us...regards overall unit tests times... can we not put it into an existing test class....? - stack > LeaseStillHeldException totally ignored by RS, wrongly named > ------------------------------------------------------------ > > Key: HBASE-2691 > URL: https://issues.apache.org/jira/browse/HBASE-2691 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Fix For: 0.20.6, 0.21.0 > > > Currently region servers don't handle org.apache.hadoop.hbase.Leases$LeaseStillHeldException in any way that's useful so what happens right now is that it tries to report to the master and this happens: > {code} > 2010-06-07 17:20:54,368 WARN [RegionServer:0] regionserver.HRegionServer(553): Attempt=1 > org.apache.hadoop.hbase.Leases$LeaseStillHeldException > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39) > at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27) > at java.lang.reflect.Constructor.newInstance(Constructor.java:513) > at org.apache.hadoop.hbase.RemoteExceptionHandler.decodeRemoteException(RemoteExceptionHandler.java:94) > at org.apache.hadoop.hbase.RemoteExceptionHandler.checkThrowable(RemoteExceptionHandler.java:48) > at org.apache.hadoop.hbase.RemoteExceptionHandler.checkIOException(RemoteExceptionHandler.java:66) > at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:541) > at org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.run(MiniHBaseCluster.java:173) > at java.lang.Thread.run(Thread.java:637) > {code} > Then it will retry until the watch is triggered telling it that the session's expired! Instead, we should be a lot more proactive initiate abort procedure. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.