hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2656) HMaster.getRegionTableClosest should not return null for closed regions
Date Mon, 21 Jun 2010 23:58:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880962#action_12880962
] 

HBase Review Board commented on HBASE-2656:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/214/#review259
-----------------------------------------------------------

Ship it!


+1 We can do others as we go.  Commit.  I wonder though if Pair is not constraining?  We should
return all in the row.  Can do that later if proves to be the case.


src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<http://review.hbase.org/r/214/#comment1109>

    Generally useful method.  Good.


- stack





> HMaster.getRegionTableClosest should not return null for closed regions
> -----------------------------------------------------------------------
>
>                 Key: HBASE-2656
>                 URL: https://issues.apache.org/jira/browse/HBASE-2656
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Priority: Blocker
>         Attachments: hbase-2656.txt
>
>
> Raised in the review of HBASE-2560: there are a couple functions in HMaster which return
null when a region has not been deployed. Instead, they should return a Pair<HRegionInfo,
HServerAddress> where only the address is null (since the info is still in meta!)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message