hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2635) ImmutableBytesWritable ignores offset in several cases
Date Tue, 01 Jun 2010 20:32:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874223#action_12874223
] 

HBase Review Board commented on HBASE-2635:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/110/#review109
-----------------------------------------------------------

Ship it!


+1


src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
<http://review.hbase.org/r/110/#comment661>

    Why this change?  Faster and good enough?


- stack





> ImmutableBytesWritable ignores offset in several cases
> ------------------------------------------------------
>
>                 Key: HBASE-2635
>                 URL: https://issues.apache.org/jira/browse/HBASE-2635
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.4, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hbase-2635.txt
>
>
> HBASE-2378 improved ImmutableBytesWritable's comparator, but there's still a bug! We
assume offset = 0, which makes the comparator function incorrectly when the ImmutableBytesWritable
is a slice into a larger byte array.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message