hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2732) TestZooKeeper was broken, HBASE-2691 showed it
Date Tue, 15 Jun 2010 21:43:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879130#action_12879130
] 

Jean-Daniel Cryans commented on HBASE-2732:
-------------------------------------------

Oh actually it's broken but not the way I was thinking. So when a session is expired we do
this in the region server;

{code}
if (state == KeeperState.Expired) {
      LOG.error("ZooKeeper session expired");
      boolean restart =
        this.conf.getBoolean("hbase.regionserver.restart.on.zk.expire", false);
      if (restart) {
        restart();
      } else {
        abort("ZooKeeper session expired");
      }
{code}

But now we get the YouAreDeadException much sooner than the session expiration, which is good,
but we don't do the restart check. Just adding it there will fix the issue. 

> TestZooKeeper was broken, HBASE-2691 showed it
> ----------------------------------------------
>
>                 Key: HBASE-2732
>                 URL: https://issues.apache.org/jira/browse/HBASE-2732
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2732.patch
>
>
> Since I committed HBASE-2691, TestZooKeeper began failing. Looking at it, it's because
it's setup with only 1 region server and we kill it... and it's not restarting. IIRC we were
relying on that feature before but looks like we're not anymore.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message