hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1025) Reconstruction log playback has no bounds on memory used
Date Mon, 14 Jun 2010 22:54:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878787#action_12878787
] 

HBase Review Board commented on HBASE-1025:
-------------------------------------------

Message from: stack@duboce.net


bq.  On 2010-06-14 14:14:55, Todd Lipcon wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, line 2017
bq.  > <http://review.hbase.org/r/179/diff/1/?file=1335#file1335line2017>
bq.  >
bq.  >     I think this will crash when the region contains stores that were the result
of an HFOF bulk load (they have no sequence id)
bq.  
bq.  stack wrote:
bq.      You mean it will throw: throw new IllegalAccessError("Has not been initialized");?
 Lets fix this.  Is this your bug from today?

How will it crash?  If all storefiles are product of HFOF, then for the Store, the maxid will
be 0 so all edits will go in.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/179/#review216
-----------------------------------------------------------





> Reconstruction log playback has no bounds on memory used
> --------------------------------------------------------
>
>                 Key: HBASE-1025
>                 URL: https://issues.apache.org/jira/browse/HBASE-1025
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.21.0
>
>         Attachments: 1025-v2.txt, 1025-v3.txt, 1025-v5.patch, 1025.txt
>
>
> Makes a TreeMap and just keeps adding edits without regard for size of edits applied;
could cause OOME (I've not seen a definitive case though have seen an OOME around time of
a reconstructionlog replay -- perhaps this the straw that broke the fleas antlers?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message