hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2728) Support for HADOOP-4829
Date Wed, 16 Jun 2010 21:01:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879491#action_12879491
] 

Jean-Daniel Cryans commented on HBASE-2728:
-------------------------------------------

Running against cloudera's release (that would also be the same with any patched hdfs), TestRegionRebalancing
fails. The issue is that we do something very dirty in HRS for tests: 

{code} 
  /** 
   * Set the hdfs shutdown thread to run on exit. Pass null to disable 
   * running of the shutdown test. Needed by tests. 
   * @param t Thread to run. Pass null to disable tests. 
   * @return Previous occupant of the shutdown thread position. 
   */ 
  public Thread setHDFSShutdownThreadOnExit(final Thread t) { 
    Thread old = this.hdfsShutdownThread; 
    this.hdfsShutdownThread = t; 
    return old; 
  } 
{code} 

So the tests pass t=null. but if we don't use the thread then we still shutdown HDFS. The
clean solution is to set shutdownHDFS.set(false) in that method and the check already in place
will do the work.

> Support for HADOOP-4829
> -----------------------
>
>                 Key: HBASE-2728
>                 URL: https://issues.apache.org/jira/browse/HBASE-2728
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.6
>
>         Attachments: HBASE-2728.patch
>
>
> Users who have a HADOOP-4829 patched hadoop will run into the issue that closing a RS
cleanly result into data loss because the FileSystem will be closed before the regions are.
Cloudera is an example. We need to support those users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message