hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2670) MemStore should retain multiple KVs with the same timestamp when memstoreTS differs
Date Wed, 16 Jun 2010 01:12:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879217#action_12879217
] 

HBase Review Board commented on HBASE-2670:
-------------------------------------------

Message from: "Ryan Rawson" <ryanobjc@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/180/#review235
-----------------------------------------------------------

Ship it!


ok looks good.  I'm also prepping a new way to do ICVs in a different issue (HBASE-2501).


src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/180/#comment1066>

    the extra KVs will make it out to hfile, but considering the problem I just don't see
a better solution right now. Perhaps collapsing extra version during the flush, but then the
question is _which_ extra versions?
    
    Maybe this will lead us to using an extra timestamp in every KeyValue on disk and in memory,
but I hope not.


- Ryan





> MemStore should retain multiple KVs with the same timestamp when memstoreTS differs
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-2670
>                 URL: https://issues.apache.org/jira/browse/HBASE-2670
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.5, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: hbase-2670.txt, hbase-2670.txt
>
>
> There appears to be a bug in HBASE-2248 as committed to trunk. See following failing
test:
> http://hudson.zones.apache.org/hudson/job/HBase-TRUNK/1296/testReport/junit/org.apache.hadoop.hbase/TestAcidGuarantees/testAtomicity/
> Think this is the same bug we saw early on in 2248 in the 0.20 branch, looks like the
fix didn't make it over.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message