hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2618) Don't inherit from HConstants
Date Thu, 10 Jun 2010 15:38:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877452#action_12877452
] 

HBase Review Board commented on HBASE-2618:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>


bq.  On 2010-06-09 23:29:32, Benoit Sigoure wrote:
bq.  > Can we apply this patch now?

Yes, can you just post your final patch into the JIRA and I will commit?  Last I checked there
were no patches in jira.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/#review173
-----------------------------------------------------------





> Don't inherit from HConstants
> -----------------------------
>
>                 Key: HBASE-2618
>                 URL: https://issues.apache.org/jira/browse/HBASE-2618
>             Project: HBase
>          Issue Type: Wish
>            Reporter: Benoit Sigoure
>            Assignee: Benoit Sigoure
>            Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants?  This is a known bad pattern
and is recommended against in many places including Effective Java (item 17).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message