hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2694) Move RS to Master region open/close messaging into ZooKeeper
Date Sat, 12 Jun 2010 01:05:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878171#action_12878171
] 

HBase Review Board commented on HBASE-2694:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>


bq.  On 2010-06-11 17:35:09, Todd Lipcon wrote:
bq.  > Skimmed it reasonably quickly, looks good.
bq.  > Major concern is how often we catch and just log exceptions. In most cases I think
these are errors we can't recover from and it's best to throw RTE and shut down the whole
server.
bq.  > 
bq.  > Several places missing license headers.

Thanks for review Todd.

In ZK refactor, we will do in-depth look at where we should be throwing RTE vs logging/swallowing
vs throwing.

When we do reimplementation of the open/close and all that, will look at the one you pointed
out.

Applied the following changes per your comments:

- Switched to foreach in event handler
- Switch to NONE.value
- Added TODOs for using guava and reviewing IOE vs LOG
- Added license headers to ZKUnassignedWatcher, TestZKBasedReopenRegion, TestZKBasedCloseRegion
- Added logging to noop closing method

Will put final patch up onto JIRA and commit.  Thanks!


bq.  On 2010-06-11 17:35:09, Todd Lipcon wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java, line 1000
bq.  > <http://review.hbase.org/r/171/diff/1/?file=1267#file1267line1000>
bq.  >
bq.  >     are these IOEs here and above really recoverable in any way? How could they
happen?

They wouldn't happen unless the Writable implementations were broken.  Not sure what we should
be doing here besides logging?  Better to log and ignore or throw RTE to bring attention to
something being very broken?

Adding TODO to review what we should do here


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/171/#review202
-----------------------------------------------------------





> Move RS to Master region open/close messaging into ZooKeeper
> ------------------------------------------------------------
>
>                 Key: HBASE-2694
>                 URL: https://issues.apache.org/jira/browse/HBASE-2694
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, regionserver
>            Reporter: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2694-OPENSOURCE-TRUNK-zk-based-messaging-v2.patch, HBASE-2694-OPENSOURCE-TRUNK-zk-based-messaging.patch
>
>
> As a first step towards HBASE-2485, this issue is about changing the message flow of
opening and closing of regions without actually changing the implementation of what happens
on both the Master and RegionServer sides.  This way we can debug the messaging changes before
the introduction of more significant changes to the master architecture and handling of regions
in transition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message