hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2400) new connector for Avro RPC access to HBase cluster
Date Thu, 10 Jun 2010 01:10:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877280#action_12877280
] 

HBase Review Board commented on HBASE-2400:
-------------------------------------------

Message from: "Jeff Hammerbacher" <jeff.hammerbacher@gmail.com>


bq.  On 2010-06-09 17:54:20, Ryan Rawson wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 111
bq.  > <http://review.hbase.org/r/128/diff/2/?file=1157#file1157line111>
bq.  >
bq.  >     do we need to make these fields nullable?  usually they are true/false in the
java code.  
bq.  >     
bq.  >     Is this some semi-mechanical translation from a java api?

I use the same Avro record for table creation and modification as well as description. For
create table, I want the fields to be nullable because the user should not have to specify
a value.


bq.  On 2010-06-09 17:54:20, Ryan Rawson wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 94
bq.  > <http://review.hbase.org/r/128/diff/2/?file=1157#file1157line94>
bq.  >
bq.  >     the compression can never be null, because the "NONE" is the catch all here.

Same as below: I use the same record for family creation, modification, and description. Avro
currently doesn't have default values on write, so making this field nullable means we can
do smart things if the user doesn't specify a compression algorithm during Family creation.


bq.  On 2010-06-09 17:54:20, Ryan Rawson wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 78
bq.  > <http://review.hbase.org/r/128/diff/2/?file=1157#file1157line78>
bq.  >
bq.  >     same as deadServerNames.

Yeah I should make these 0-length arrays.


bq.  On 2010-06-09 17:54:20, Ryan Rawson wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 73
bq.  > <http://review.hbase.org/r/128/diff/2/?file=1157#file1157line73>
bq.  >
bq.  >     couldnt you use a empty string if there are no dead server names?  im not sure
if arrays can be 0 length in avro :-)

Will make a 0-length array


bq.  On 2010-06-09 17:54:20, Ryan Rawson wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 66
bq.  > <http://review.hbase.org/r/128/diff/2/?file=1157#file1157line66>
bq.  >
bq.  >     technically the serverName is the serverAddress + startCode... in the Java code
is isnt fully exposed.  Not sure what we want to do here, but this is probably fine as is.

Yeah since Avro records don't have methods, you can think of this field as a materialization
of the Java logic.


bq.  On 2010-06-09 17:54:20, Ryan Rawson wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 34
bq.  > <http://review.hbase.org/r/128/diff/2/?file=1157#file1157line34>
bq.  >
bq.  >     you can probably just use 'hostname' and 'port'.  There was a recent patch in
trunk that is attempting to get rid of IP addresses (they cause issues when they dont align
with DNS names, etc) and generally move us to a DNS name world.

Let me know what you want me to do here. I was just copying the fields directly from the Java
objects.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/#review164
-----------------------------------------------------------





> new connector for Avro RPC access to HBase cluster
> --------------------------------------------------
>
>                 Key: HBASE-2400
>                 URL: https://issues.apache.org/jira/browse/HBASE-2400
>             Project: HBase
>          Issue Type: Task
>          Components: avro
>            Reporter: Andrew Purtell
>            Priority: Minor
>         Attachments: HBASE-2400-v0.patch
>
>
> Build a new connector contrib architecturally equivalent to the Thrift connector, but
using Avro serialization and associated transport and RPC server work. Support AAA (audit,
authentication, authorization). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message