Return-Path: 
 <issues-return-1825-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: (qmail 28794 invoked from network); 19 May 2010 20:49:20 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 19 May 2010 20:49:20 -0000
Received: (qmail 45839 invoked by uid 500); 19 May 2010 20:49:20 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 45814 invoked by uid 500); 19 May 2010 20:49:20 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 45806 invoked by uid 500); 19 May 2010 20:49:20 -0000
Delivered-To: apmail-hadoop-hbase-issues@hadoop.apache.org
Received: (qmail 45803 invoked by uid 99); 19 May 2010 20:49:20 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 May 2010 20:49:20 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 May 2010 20:49:18 +0000
Received: from thor (localhost [127.0.0.1])
	by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4JKmuBk018473
	for <hbase-issues@hadoop.apache.org>; Wed, 19 May 2010 20:48:56 GMT
Message-ID: <26135327.23611274302136713.JavaMail.jira@thor>
Date: Wed, 19 May 2010 16:48:56 -0400 (EDT)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-issues@hadoop.apache.org
Subject: [jira] Commented: (HBASE-1200) Add bloomfilters
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869329#action_12869329 ] 

stack commented on HBASE-1200:
------------------------------

Nicolas:

{code}
     // For each file, obtain a scanner:
-    List<KeyValueScanner> scanners = StoreFileScanner.getScannersForStoreFiles(
-        filesToCompact, false, false);
+    List<StoreFileScanner> sfScanners = StoreFileScanner
+    .getScannersForStoreFiles(filesToCompact, false, false);
+    List<KeyValueScanner> scanners =
+      new ArrayList<KeyValueScanner>(sfScanners.size()+1);

{code}

Something wrong in the above.  We make new scanners List but we don't add the sfScanners to it that I can see.

> Add bloomfilters
> ----------------
>
>                 Key: HBASE-1200
>                 URL: https://issues.apache.org/jira/browse/HBASE-1200
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.20.5
>            Reporter: stack
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.21.0
>
>         Attachments: 1200-trunk.txt, Bloom Filters in HBase.docx, Bloom_Filters_in_HBase.pdf, HBASE-1200-0.20.5-4.patch, HBASE-1200-0.20.5.patch, hbase-1200-0.20branch-v2.txt, ryan_bloomfilter.patch, Store.java.rej, StoreScanner.java.rej
>
>
> Add bloomfiltering to hfile.  Can be enabled on a family-level basis.  Ability to configure a row vs row+col level bloom.  We size the bloomfilter with the number of entries we are about to flush which seems like usually we'd be making a filter too big, so our implementation needs to take that into account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.