Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <15651572.3461274670117570.JavaMail.jira@thor>
Date: Sun, 23 May 2010 23:01:57 -0400 (EDT)
From: "HBase Review Board (JIRA)" <jira@apache.org>
To: hbase-issues@hadoop.apache.org
Subject: [jira] Commented: (HBASE-2589) TestHRegion.testWritesWhileScanning
 flaky on trunk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870493#action_12870493 ] 

HBase Review Board commented on HBASE-2589:
-------------------------------------------

Message from: "Todd Lipcon" <todd@cloudera.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/79/
-----------------------------------------------------------

(Updated 2010-05-23 19:59:07.555469)


Review request for hbase and Ryan Rawson.


Changes
-------

Switched to a short Thread.sleep instead.
Also got rid of the accessor, since I'm only accessing that variable internally.


Summary
-------

Test wasn't waiting until the put thread had started before it started reading, so would often fail having read 0 columns.


This addresses bug HBASE-2589.
    http://issues.apache.org/jira/browse/HBASE-2589


Diffs (updated)
-----

  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 44e7e6d 

Diff: http://review.hbase.org/r/79/diff


Testing
-------

Ran it a few times on my box locally, seems to pass now where it used to fail most of the time.


Thanks,

Todd


> TestHRegion.testWritesWhileScanning flaky on trunk
> --------------------------------------------------
>
>                 Key: HBASE-2589
>                 URL: https://issues.apache.org/jira/browse/HBASE-2589
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hbase-2589.txt
>
>
> IIRC we added this test in response to a bug in HBASE-2248 in the old branch. It's failing about half the time on my internal Hudson. i=36 expected:<1000> but was:<0>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.