hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2613) Remove the code around MSG_CALL_SERVER_STARTUP
Date Wed, 26 May 2010 22:13:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871974#action_12871974
] 

HBase Review Board commented on HBASE-2613:
-------------------------------------------

Message from: "Jean-Daniel Cryans" <jdcryans@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/89/
-----------------------------------------------------------

(Updated 2010-05-26 15:12:24.679274)


Review request for hbase.


Changes
-------

New patch with test for master. Spawns a 3 nodes cluster, kills 2 by changing the startcode
and address.


Summary
-------

Patch that removes all the MSG_CALL_SERVER_STARTUP related code that was screwing us more
than helping us. Now, when a region server pings back with a different start code, we just
shut it down.


This addresses bug HBASE-2613.


Diffs (updated)
-----

  /trunk/src/main/java/org/apache/hadoop/hbase/HMsg.java 948611 
  /trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 948611 
  /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 948611 
  /trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java PRE-CREATION


Diff: http://review.hbase.org/r/89/diff


Testing
-------


Thanks,

Jean-Daniel




> Remove the code around MSG_CALL_SERVER_STARTUP
> ----------------------------------------------
>
>                 Key: HBASE-2613
>                 URL: https://issues.apache.org/jira/browse/HBASE-2613
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>
> Currently we have a weird piece of code in the master that handles region servers that
report but that we don't know about. People likely see:
> {code}
>       LOG.warn("Received report from unknown server -- telling it " +
>         "to " + HMsg.CALL_SERVER_STARTUP + ": " + info.getServerName());
> {code}
> But I never saw that working.correctly, usually the region server will restar-ish and
we will likely end up with double assignment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message