hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2508) Use AtomicInteger for lockIdGenerator in HRegion
Date Sun, 02 May 2010 19:31:56 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863187#action_12863187

Ted Yu commented on HBASE-2508:

lockIdGenerator isn't declared volatile.

Also, when lockIds.put(lockId, prev) is called to put back old value in case of collision,
there would be momentary inconsistency between lockId and low.

> Use AtomicInteger for lockIdGenerator in HRegion
> ------------------------------------------------
>                 Key: HBASE-2508
>                 URL: https://issues.apache.org/jira/browse/HBASE-2508
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.20.3
>            Reporter: Ted Yu
> Currently lockIdGenerator is an int. In obtainRowLock(), retry is needed in case of lockId
> We can declare lockIdGenerator as AtomicInteger and use incrementAndGet() to get the
next lock Id.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message