hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2578) Add ability for tests to override server-side timestamp setting (currentTimeMillis)
Date Wed, 26 May 2010 01:18:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871471#action_12871471
] 

HBase Review Board commented on HBASE-2578:
-------------------------------------------

Message from: "Ryan Rawson" <ryanobjc@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/#review72
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
<http://review.hbase.org/r/83/#comment393>

    this is a lot of synchronization for what ends up being on the fast path of every query,
perhaps there is a non synchronized manner in which we can accomplish this?  the use of volatile
might help here


- Ryan






> Add ability for tests to override server-side timestamp setting (currentTimeMillis)
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-2578
>                 URL: https://issues.apache.org/jira/browse/HBASE-2578
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jonathan Gray
>            Assignee: Daniel Ploeg
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2578.txt, HBASE-2578_take2.txt
>
>
> Many of our tests use client APIs which do not set explicit stamps.  This creates weird
timing issues with tests running on different systems because sometimes a set of operations
happens in the same millisecond and other times they do not.
> We should have a way for a test to specify it's own way of generating the timestamps
(for example, could always increment by 1 ensuring forward progression in time).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message