hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2399) Forced splits only act on the first family in a table
Date Thu, 01 Apr 2010 18:45:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852503#action_12852503
] 

Jonathan Gray commented on HBASE-2399:
--------------------------------------

The posted patch is itself broken, but turns out that the existing test doesn't actually fail
if the table doesn't split.  It waits around for the split, but even if it goes past the max
loops, it doesn't actually ever fail any assertions.

I'm also fixing the test itself in my HBASE-2375 patch.  More to come.

> Forced splits only act on the first family in a table
> -----------------------------------------------------
>
>                 Key: HBASE-2399
>                 URL: https://issues.apache.org/jira/browse/HBASE-2399
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.3
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.20.4, 0.21.0
>
>         Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the existing code
related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and then triggers
a compaction (this is very similar to my current implementation for HBASE-2375).  However,
the forceSplit boolean is flipped back to false at the beginning of Store.compact().  So the
force split only acts on the first family in the table.  If that Store is not splittable for
some reason (it is empty or has only one row), then the entire region will not be split, regardless
of what is in other families.
> Even if there is data in the first family, the midKey is determined based solely on that
family.  If it has two rows and the next family has 1M rows, we pick the split key based on
the two rows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message