hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-22936) Close memStoreScanners in StoreScanner#updateReaders else memory leak
Date Wed, 02 Oct 2019 11:48:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-22936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Duo Zhang resolved HBASE-22936.
-------------------------------
      Assignee:     (was: Sandeep Pal)
    Resolution: Implemented

Already implemented by other issues, for branch-2.1, it is HBASE-22929.

> Close memStoreScanners in StoreScanner#updateReaders else memory leak
> ---------------------------------------------------------------------
>
>                 Key: HBASE-22936
>                 URL: https://issues.apache.org/jira/browse/HBASE-22936
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Michael Stack
>            Priority: Major
>             Fix For: 2.3.0, 2.1.7, 2.2.2
>
>
> Via [~aoxiang] from over on HBASE-22723
> {code}
> +      if (!closeLock.tryLock()) {
> +        // no lock acquired.
> +        LOG.debug("StoreScanner already has the close lokc. There is no need to updateReaders");
> +        return;
> +      }
> +      // lock acquired
> +      updateReaders = true;
> +      if (this.closing) {
> +        LOG.debug("StoreScanner already closing. There is no need to updateReaders");
> +        return;
> +      }
> {code}
> We need to close memStoreScanners in StoreScanner#updateReaders before this two return,
someone else can take over the task.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message