hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hbase] VincentChoiCN opened a new pull request #109: fix a bug of checking if restoreDir is subDir of rootDir
Date Wed, 20 Mar 2019 03:29:58 GMT
VincentChoiCN opened a new pull request #109: fix a bug of checking if restoreDir is subDir
of rootDir
URL: https://github.com/apache/hbase/pull/109
 
 
   The restoreDir shouldn't be a sub directory of rootDir. The code check it with a prefix
check "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it goes error
in some reasonable cases.
   
   eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I think it's
more reasonable to chang the code to "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath()
+ "/" )".
   
   jira:https://issues.apache.org/jira/browse/HBASE-22070

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message