hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Elser <els...@apache.org>
Subject Re: [DISCUSS] test-for-tests in precommit
Date Fri, 13 Jul 2018 15:34:09 GMT
+1

On 7/13/18 11:28 AM, Sean Busbey wrote:
> Hi folks!
> 
> Given how often we end up accepting contributions despite
> test-for-tests complaining about lack of changed or new tests would
> anyone be opposed to me changing its vote from -1 to -0?
> 
> The rationale for discounting its -1 looked reasonable in the issues I
> sampled. It usually was either some change that fixes a problem we
> can't test due to limitations in our test suite or  an optimization
> that's covered by existing tests.
> 
> Maybe in the future if we get to a point where we're including nightly
> feature-specific cluster tests we could update it to recognize changes
> to that and then turn it back to having a vote that can fail the
> precommit test run.
> 

Mime
View raw message