From dev-return-68234-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Mon Feb 26 23:04:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ABB1E18064A for ; Mon, 26 Feb 2018 23:04:08 +0100 (CET) Received: (qmail 63673 invoked by uid 500); 26 Feb 2018 22:04:02 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 63662 invoked by uid 99); 26 Feb 2018 22:04:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2018 22:04:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 07287C0111 for ; Mon, 26 Feb 2018 22:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id lhp4oeTwGP4a for ; Mon, 26 Feb 2018 22:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0E08C5F2F1 for ; Mon, 26 Feb 2018 22:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6BB23E01D8 for ; Mon, 26 Feb 2018 22:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D0F5255DA for ; Mon, 26 Feb 2018 22:04:00 +0000 (UTC) Date: Mon, 26 Feb 2018 22:04:00 +0000 (UTC) From: "Ted Yu (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-20090) Properly handle Preconditions check failure in MemStoreFlusher$FlushHandler.run MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ted Yu created HBASE-20090: ------------------------------ Summary: Properly handle Preconditions check failure in MemStoreFlusher$FlushHandler.run Key: HBASE-20090 URL: https://issues.apache.org/jira/browse/HBASE-20090 Project: HBase Issue Type: Bug Reporter: Ted Yu Here is the code in branch-2 : {code} try { wakeupPending.set(false); // allow someone to wake us up again fqe = flushQueue.poll(threadWakeFrequency, TimeUnit.MILLISECONDS); if (fqe == null || fqe instanceof WakeupFlushThread) { ... if (!flushOneForGlobalPressure()) { ... FlushRegionEntry fre = (FlushRegionEntry) fqe; if (!flushRegion(fre)) { break; ... } catch (Exception ex) { LOG.error("Cache flusher failed for entry " + fqe, ex); if (!server.checkFileSystem()) { break; } } {code} Inside flushOneForGlobalPressure(): {code} Preconditions.checkState( (regionToFlush != null && regionToFlushSize > 0) || (bestRegionReplica != null && bestRegionReplicaSize > 0)); {code} When the Preconditions check fails, IllegalStateException is caught by the catch block shown above. However, the fqe is not flushed, resulting in potential data loss. -- This message was sent by Atlassian JIRA (v7.6.3#76005)