From dev-return-67961-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Fri Feb 9 22:09:46 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A1EFE180654 for ; Fri, 9 Feb 2018 22:09:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 917D3160C4C; Fri, 9 Feb 2018 21:09:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D72F8160C3C for ; Fri, 9 Feb 2018 22:09:45 +0100 (CET) Received: (qmail 44262 invoked by uid 500); 9 Feb 2018 21:09:44 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 44251 invoked by uid 99); 9 Feb 2018 21:09:44 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 21:09:44 +0000 Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com [209.85.218.44]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 6B8AA291B for ; Fri, 9 Feb 2018 21:09:43 +0000 (UTC) Received: by mail-oi0-f44.google.com with SMTP id t78so7095832oih.4 for ; Fri, 09 Feb 2018 13:09:42 -0800 (PST) X-Gm-Message-State: APf1xPDmmPNv/X7+qXK7whkvRIwg4TIiR+9J9lY3P1WPcCq+Gonv5LDS gzY54Hr82h0vQMYQ4UMVAHxnX9+/9oqXJzj9VjA= X-Google-Smtp-Source: AH8x226JPJ8LPIFI7DiXq26c35zVbP/DDKltM2n80wUy3J8UwAqe7Lqs8X5i/uxAZ+PJCdFbAolXjAq6hGBhAi9TBS4= X-Received: by 10.202.50.3 with SMTP id y3mr2858557oiy.286.1518210582012; Fri, 09 Feb 2018 13:09:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.61.200 with HTTP; Fri, 9 Feb 2018 13:09:01 -0800 (PST) In-Reply-To: References: From: Andrew Purtell Date: Fri, 9 Feb 2018 13:09:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: QuotaExceededException as a DoNotRetryIOException? To: dev@hbase.apache.org Content-Type: multipart/alternative; boundary="001a113cf13e6f6bb90564cdf248" --001a113cf13e6f6bb90564cdf248 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We have public class ThrottlingException extends QuotaExceededException public class QuotaExceededException extends DoNotRetryIOException Let the storage quota limits throw QuotaExceededException directly (based on DNRIOE). That seems fine. However,=E2=80=8B =E2=80=8BThrottlingException is thrown as a result of a t= emporal quota, so it is inappropriate for this to inherit from DNRIOE, it should inherit IOException instead so the client is allowed to retry until successful, or until the retry policy is exhausted. We=E2=80=8B =E2=80=8B are in a bit of a pickle because we've released with = this inheritance hierarchy, so to change it we will need a new minor, or we will want to deprecate ThrottlingException and use a new exception class instead, one which does not inherit from DNRIOE. On Wed, Feb 7, 2018 at 8:23 AM, Stack wrote: > QEE being a DNRIOE seems right on the face of it. > > But if throttling, a DNRIOE is inappropriate. Where you seeing a QEE in a > throttling scenario Huaxiang? > > Thanks, > S > > > On Tue, Feb 6, 2018 at 4:56 PM, Huaxiang Sun wrote: > > > Hi HBase devs, > > > > I found that QuotaExceededException is a DoNotRetryIOException, > which > > is a bit strange from user=E2=80=99s point of view. > > For rpc throttling, the exception is retryable and it tells app to > > slow down and retry later. > > > > Any thoughts? > > > > Thanks, > > Huaxiang > --=20 Best regards, Andrew Words like orphans lost among the crosstalk, meaning torn from truth's decrepit hands - A23, Crosstalk --001a113cf13e6f6bb90564cdf248--