Return-Path: <dev-return-66915-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id BBE3D200D5B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 13 Dec 2017 07:38:04 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id BA624160C23; Wed, 13 Dec 2017 06:38:04 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0C8ED160C16
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 13 Dec 2017 07:38:03 +0100 (CET)
Received: (qmail 56626 invoked by uid 500); 13 Dec 2017 06:38:02 -0000
Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hbase.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hbase.apache.org>
List-Post: <mailto:dev@hbase.apache.org>
List-Id: <dev.hbase.apache.org>
Reply-To: dev@hbase.apache.org
Delivered-To: mailing list dev@hbase.apache.org
Received: (qmail 56614 invoked by uid 99); 13 Dec 2017 06:38:02 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Dec 2017 06:38:02 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 73BDB1A10FA
	for <dev@hbase.apache.org>; Wed, 13 Dec 2017 06:38:02 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -100.002
X-Spam-Level: 
X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31
	tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001,
	USER_IN_WHITELIST=-100] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id DlDB1GdVIMup for <dev@hbase.apache.org>;
	Wed, 13 Dec 2017 06:38:01 +0000 (UTC)
Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1D4595F3CF
	for <dev@hbase.apache.org>; Wed, 13 Dec 2017 06:38:01 +0000 (UTC)
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5A4D4E04F4
	for <dev@hbase.apache.org>; Wed, 13 Dec 2017 06:38:00 +0000 (UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
	by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 14050212FA
	for <dev@hbase.apache.org>; Wed, 13 Dec 2017 06:38:00 +0000 (UTC)
Date: Wed, 13 Dec 2017 06:38:00 +0000 (UTC)
From: "Chia-Ping Tsai (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.13124585.1513147058000.445720.1513147080076@Atlassian.JIRA>
In-Reply-To: <JIRA.13124585.1513147058000@Atlassian.JIRA>
References: <JIRA.13124585.1513147058000@Atlassian.JIRA> <JIRA.13124585.1513147058837@jira-lw-us.apache.org>
Subject: [jira] [Created] (HBASE-19502) Make sure we have closed all
 StoreFileScanner if we fail to open any StoreFileScanners
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 13 Dec 2017 06:38:04 -0000

Chia-Ping Tsai created HBASE-19502:
--------------------------------------

             Summary: Make sure we have closed all StoreFileScanner if we fail to open any StoreFileScanners
                 Key: HBASE-19502
                 URL: https://issues.apache.org/jira/browse/HBASE-19502
             Project: HBase
          Issue Type: Sub-task
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai


{code:title=StoreFileScanner.java}
  public static List<StoreFileScanner> getScannersForStoreFiles(Collection<StoreFile> files,
      boolean cacheBlocks, boolean usePread, boolean isCompaction, boolean canUseDrop,
      ScanQueryMatcher matcher, long readPt, boolean isPrimaryReplica) throws IOException {
    List<StoreFileScanner> scanners = new ArrayList<StoreFileScanner>(files.size());
    List<StoreFile> sorted_files = new ArrayList<>(files);
    Collections.sort(sorted_files, StoreFile.Comparators.SEQ_ID);
    for (int i = 0; i < sorted_files.size(); i++) {
      StoreFile.Reader r = sorted_files.get(i).createReader(canUseDrop);
      r.setReplicaStoreFile(isPrimaryReplica);
      StoreFileScanner scanner = r.getStoreFileScanner(cacheBlocks, usePread, isCompaction, readPt,
        i, matcher != null ? !matcher.hasNullColumnInQuery() : false);
      scanners.add(scanner);
    }
    return scanners;
  }
{code}
The missed decrement of ref count will obstruct the cleanup of compacted files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)