Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Subject: Re: Empty hbase-shaded-client JAR file
To: dev@hbase.apache.org
References: <CAFAMeYKfr0Evpcwh3XdrxBv3yEys=oge7TEmhuwAB7py0brfoQ@mail.gmail.com>
 <000501d35502$2b7f3990$827dacb0$@comcast.net>
 <CAN5cbe5Y03EbqUXAGQZ1Z_fv9y5fnzR0cos23ehGtLQVQtknqw@mail.gmail.com>
 <pony-5c0191c5bda2836af1cb87878694cfbf1db676c8-3c90c298a02f49ef1ec492d733c6919d919f9a6a@dev.hbase.apache.org>
 <006701d35737$83ebe8d0$8bc3ba70$@comcast.net>
From: Josh Elser <elserj@apache.org>
Message-ID: <7025e60b-7203-e124-d9e9-a1526bdcfc9e@apache.org>
Date: Mon, 6 Nov 2017 15:09:00 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:56.0)
 Gecko/20100101 Thunderbird/56.0
MIME-Version: 1.0
In-Reply-To: <006701d35737$83ebe8d0$8bc3ba70$@comcast.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Nov 2017 20:09:08 -0000

You interested in opening up a JIRA issue for this change and/or making 
such a doc-change, Rick?

Otherwise, someone here will do it for you.

On 11/6/17 2:43 PM, Rick Kellogg wrote:
> Greetings,
> 
> I just had an opportunity to review the current HBase Reference Guide.  No
> were in there does it even mention the hbase-shaded-client.  There is a
> discussion of Protobufs and shading of such.
> 
> I would suggest adding documentation on hbase-shaded-client and add a note
> under section 147.1.7 Build Gotchas: Where are my shaded jars files?
> 
> Many thanks for your assistance.
> Rick Kellogg
> 
> -----Original Message-----
> From: Sean Busbey [mailto:busbey@apache.org]
> Sent: Saturday, November 4, 2017 8:17 PM
> To: dev@hbase.apache.org
> Subject: Re: Empty hbase-shaded-client JAR file
> 
> Between the addition of the shaded jars in 1.1.0 and 1.1.1/1.2.0 building
> the shaded jars was moved to the release profile after complaints about how
> much time was added to the build by doing them all the time.
> 
> I think all the discussion was on JIRA:
> 
> https://issues.apache.org/jira/browse/HBASE-13816
> 
> Rick, is there some place we could have called out this detail in docs to
> save you time?
> 
> 
> 
> On 2017-11-03 20:49, Mike Drob <mdrob@apache.org> wrote:
>> Sean,
>>
>> Is this a historical vestige? Why can't we populate the shaded jars
> always?
>>
>>
>>
>> On Fri, Nov 3, 2017 at 7:51 PM, Sean Busbey <busbey@apache.org> wrote:
>>
>>> Hi Rick!
>>>
>>> You have to build with the "release" profile active for the shaded
>>> jars to be populated
>>>
>>> e.g.:
>>>
>>> mvn -Prelease -DskipTests clean install
>>>
>>>
>>>
>>> On Fri, Nov 3, 2017 at 7:16 PM, Rick Kellogg <rmkellogg@comcast.net>
>>> wrote:
>>>> Greetings,
>>>>
>>>>
>>>>
>>>> I have been trying to build the latest HBase using the master branch.
>>> When
>>>> the hbase-sharded-client JAR file is generated, it does not include
> any
>>>> .class files.  Build completes without any errors.   Any ideas what
>>> might be
>>>> causing this issue?
>>>>
>>>>
>>>>
>>>> Attempted Maven Commands:  mvn package -DskipTests=true   and mvn
> install
>>>> -DskipTests=true
>>>>
>>>>
>>>>
>>>> Environnent: RHEL 7.3, Maven 3.5.0, Oracle JDK 1.8.0_152.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Rick Kellogg
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>