hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-19367) Refactoring in RegionStates, and RSProcedureDispatcher
Date Tue, 28 Nov 2017 20:15:00 GMT
Appy created HBASE-19367:
----------------------------

             Summary: Refactoring in RegionStates, and RSProcedureDispatcher
                 Key: HBASE-19367
                 URL: https://issues.apache.org/jira/browse/HBASE-19367
             Project: HBase
          Issue Type: Improvement
            Reporter: Appy
            Assignee: Appy
            Priority: Minor


Working on a bug fix, was in these parts for first time to understand new AM and trying to
make sense of things. Did a few improvements on the way.

- Adding javadoc comments
- Bug: ServerStateNode#regions is HashSet but there's no synchronization to prevent concurrent
add/removes. Let's use concurrent set instead.
- Use getRegionsInTransitionCount() directly to avoid instead of getRegionsInTransition().size()
because the latter copies everything into a new array - what a waste for just the size.
- There's mixed use of getRegionNode and getRegionStateNode for same return type - RegionStateNode.
Changing everything to getRegionStateNode. Similarly rename other *RegionNode() fns to *RegionStateNode().
- RegionStateNode#transitionState() return value is useless since it always returns it's first
param.
- Other minor improvements



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message