Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
To: HBase Dev List <dev@hbase.apache.org>
From: Josh Elser <josh.elser@gmail.com>
Subject: PreCommit whitespace failures on JVM crash dump files
Message-ID: <d368b925-a18d-b88c-ed34-c238a83f1a78@gmail.com>
Date: Mon, 23 Oct 2017 11:45:09 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:56.0)
 Gecko/20100101 Thunderbird/56.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
archived-at: Mon, 23 Oct 2017 15:45:09 -0000

Hiya,

Noticed a PreCommit failure from over the weekend on the whitespace 
(EOL, tabs) checks [1][2]:

e.g.

```
./hbase-server/hs_err_pid30492.log:637:731000000-734f00000 rw-p 00000000 
00:00 0
./hbase-server/hs_err_pid30492.log:638:734f00000-751000000 rw-p 00000000 
00:00 0
```

Any thoughts on the right way to fix this one?

The whitespace check ran before the tests did, so I can only assume 
these were laying around on the filesystem before the PreCommit job 
itself ran. Do we need to be a bit more aggressive in the clean steps?

I do see in the Jenkinsfile, we are taking advantage of the options in 
Yetus to ignore certain files for whitespace. That would be another 
option to "fix" this.

- Josh

[1] 
https://builds.apache.org/job/PreCommit-HBASE-Build/9309/artifact/patchprocess/whitespace-eol.txt
[2] 
https://builds.apache.org/job/PreCommit-HBASE-Build/9309/artifact/patchprocess/whitespace-tabs.txt