Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4A1F6200D28 for ; Mon, 23 Oct 2017 21:17:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 48CD11609E0; Mon, 23 Oct 2017 19:17:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9149F1609DF for ; Mon, 23 Oct 2017 21:17:14 +0200 (CEST) Received: (qmail 50979 invoked by uid 500); 23 Oct 2017 19:17:13 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 50961 invoked by uid 99); 23 Oct 2017 19:17:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 19:17:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7AEA7C1D1C for ; Mon, 23 Oct 2017 19:17:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3Gs49kmrsroF for ; Mon, 23 Oct 2017 19:17:11 +0000 (UTC) Received: from mail-ua0-f169.google.com (mail-ua0-f169.google.com [209.85.217.169]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 62B8A5FD67 for ; Mon, 23 Oct 2017 19:17:11 +0000 (UTC) Received: by mail-ua0-f169.google.com with SMTP id e46so13714622uaa.4 for ; Mon, 23 Oct 2017 12:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=KpbEwzMtKm1JYF3kPVPgeFoMhHXpJY058kGiAR45bNw=; b=czNlEfOu9u0q09JT/Hg10jenSOIW8cGrvnXVshoylk/6YfVuHnfNwdNXZKQF4IPWKe onMaDseikyq4yPPc55NjaqjQVDapiVL2ytBWHl7XjgaeKWx2EMUWW885Gp+TCZo1AMGi SC9/O7h/xBpaXRuv3Ks+4XPjI2benHKryQJvyk5eR5ehXBcYhxp4luCGUrKPs8rf0Rr9 ak/u8rRLZ4IcmkUPuepKZ7/XFfQL2+u3MOVoVhg/w9OLA6jT4/9lEZZGg0tw5UmBV1DS q5jVisCJ2vN9Ct6qaHpwyY8BDxCO1U7oVoXlKrilxxDWKgc6Kr47EHleAIMJaohn3UZZ 9szg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KpbEwzMtKm1JYF3kPVPgeFoMhHXpJY058kGiAR45bNw=; b=nY0VwLMFN06irARvuEK1cksy2bHg5fstrtanyBQnFUB0Fdr1eZEPQ0WygsHLd5V6JU IelFfoUQZ5UBD9dyMwpegGxYXZm0klDuFL92Q4u2mIWLa/DuoG5jSVUxdLHCIJFeuK6q o7QyHGOXONdymgBwMCyCjvYO0u37nxQpvkd7oUZ0iuU1JDa+KEGAr4nZytHp18KpThUO /KBrM7kAzx2t6vTgLtqnreNwZshgELKfniIs7cFo9SW6yl/Yn3e9SWM8xS/ILfoqKSE4 ZzAxh+ayVWSve5UtPKTo4UeAWEeMkPit8kVH9lSM+zNp+yE3AmOxmFkAfEADl3qQnZi+ NNNw== X-Gm-Message-State: AMCzsaVWn25wfjKnLda3qOeswlt/KdqCsB9BRFGW6T/CWkWmMq9YJ9yS rGAGmUaSD4/+z1OIDyKuBJLls7bRd7namW06JpmFfF8= X-Google-Smtp-Source: ABhQp+ToxIe01+fBLSRtAkTbgfuaaZUz8HVzX5nSZYa0MQLrLlURTfdsbepyLVI6Gy0XiT4ObBo0ID1DN2r1eBsRwxQ= X-Received: by 10.159.35.107 with SMTP id 98mr10383832uae.190.1508786230590; Mon, 23 Oct 2017 12:17:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.236.4 with HTTP; Mon, 23 Oct 2017 12:16:40 -0700 (PDT) From: Apekshit Sharma Date: Mon, 23 Oct 2017 12:16:40 -0700 Message-ID: Subject: [DISCUSS] Fate of CoordinatedStateManager and hbase.coordinated.state.manager.class config To: dev@hbase.apache.org Content-Type: multipart/alternative; boundary="001a113d10025120d7055c3bab20" archived-at: Mon, 23 Oct 2017 19:17:15 -0000 --001a113d10025120d7055c3bab20 Content-Type: text/plain; charset="UTF-8" Hi everyone, Am coming from limited knowledge here, so pardon me if it seems outrageous. I guess this effort (HBASE-10909 ) was to separate out state into an interface which was then made pluggable via the config hbase.coordinated.state.manager.class. - Is this effort complete? Can someone use it to completely switch out ZK based state with something else? I see all tasks in HBASE-10909 are complete, but it's named 'phase1' and i don't see a phase2. - Is anyone aware of any use cases where it's actually being used to replace zk? ** If yes, I think that at the very least, we should clean it up (more on it further down) and made these relevant interfaced IA.Public. ** If not, can we get rid of the (incomplete??) 'feature' and do more rigorous cleanup? I'll sign up for it. --------- Cleanup: Our internal class hierarchy is: CoordinatedStateManager -> BaseCoordinatedStateManager -> ZkCoordinatedStateManager. - We carry around CSM objects but cast them to BCSM in so many places! If anyone implements CSM and plugs it in, it won't work. Better to just unify them and make it easier to understand. -- Appy --001a113d10025120d7055c3bab20--