Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B8DB7200CFC for ; Thu, 28 Sep 2017 16:07:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B72E71609CD; Thu, 28 Sep 2017 14:07:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0706B1609C2 for ; Thu, 28 Sep 2017 16:07:03 +0200 (CEST) Received: (qmail 34818 invoked by uid 500); 28 Sep 2017 14:06:58 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 34806 invoked by uid 99); 28 Sep 2017 14:06:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Sep 2017 14:06:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3C2A5D205E for ; Thu, 28 Sep 2017 14:06:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.379 X-Spam-Level: X-Spam-Status: No, score=0.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Ogmi_mgY2yb6 for ; Thu, 28 Sep 2017 14:06:52 +0000 (UTC) Received: from mail-yw0-f175.google.com (mail-yw0-f175.google.com [209.85.161.175]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 97F9761127 for ; Thu, 28 Sep 2017 14:06:52 +0000 (UTC) Received: by mail-yw0-f175.google.com with SMTP id r85so1070181ywg.1 for ; Thu, 28 Sep 2017 07:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=ZgTNcsFU3NkjlD9sLq2UPWBC64mUQ7R+BUdF8eoww8M=; b=lr1/Xu4MFLGL460cAKIth+KoJDiLw2cbOt8Yc5Vro6fLPwe3UjZvC41gvn9G/vbjhg f3AZgRA+b5hqLQ4NebX7wEV3ZcrjuzKfbLxbXMQLTqwKirLZ4ldH0LB6Ks+ImPduA7QX vDpQdJ4KZoNmvlUFqHnrdykD1VlBJMqDjjjr5VDoizR1kduvzcrA1B0NF9XsymeMIymh rYbWSPREMZVriS3OhZo/B9Gfus5a8DwvL+VNlT3BCLpttl+Ry0bGDFrq0P5kVO3ebZmq xFCnaBlj/cgfhNZoiZSObkOr0IaZTFAnyp+yQQrtXQE4RUkDm1dIBBBoqwXBR319/B63 4+lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=ZgTNcsFU3NkjlD9sLq2UPWBC64mUQ7R+BUdF8eoww8M=; b=eXoL2+N4BszoeeWmgOhqjqnkFa5QOatjYosQZpHL+vrgWQHVtm8R0s3WgiviJuM/tJ inyc+S2rzTjUyOXKDhRdQAa4gK4QhBwyS40k2TMfGPtQa0fWnMx5i9Sa57O4347rv+QS BhVOrrh/BghSFzcqQIRedoIf9RubIN89NMi3UKQeDWdbNWQoQ6UH2neOZ1oQqFdfi3DJ uaD3/DS9prSBPNykiJ8AhyWFv4Y5bxEUbRxLLjGgALIrOBkbEeg0OdcLxgiHuWruA8jH SaMx3YSbCO/0JTkRZ2VaZmsO78IB1r6VGCfUJfiLfASTQw3A376u2EFzMS9bJUtWOe+Q Wnbw== X-Gm-Message-State: AHPjjUiXphoKcJ6IMGCjIX1zztqmNYpLtHz3ssuzelYI2A5ZVhIsGmTl beAHqY0/27656avuItfnGtxkpw/ZzU5TOFVExJM= X-Google-Smtp-Source: AOwi7QBnM2xakYHXq8czWUjXbxt1LMK7eSJTgla5ZieoTwbzkTeA/4lzBUlCcd5Y252S7o1mH0CfV3ChXmfaTcV8/8k= X-Received: by 10.37.6.133 with SMTP id 127mr2059706ybg.236.1506607611910; Thu, 28 Sep 2017 07:06:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.54.21 with HTTP; Thu, 28 Sep 2017 07:06:51 -0700 (PDT) In-Reply-To: References: From: Anoop John Date: Thu, 28 Sep 2017 19:36:51 +0530 Message-ID: Subject: Re: [DISCUSS] Move Type out of KeyValue To: "dev@hbase.apache.org" Content-Type: text/plain; charset="UTF-8" archived-at: Thu, 28 Sep 2017 14:07:04 -0000 Moving out of KV means it is BC break right? Even though KV is Private, using that only client side can create cell objects (At least Type specify) . Should we have a deprecation cycle? Deprecate KV.Type and add Cell.Type (?) -Anoop- On Thu, Sep 28, 2017 at 5:14 PM, Ted Yu wrote: > How about choosing option #2 ? > > Cell is annotated Public. > > On Thu, Sep 28, 2017 at 2:25 AM, Chia-Ping Tsai wrote: > >> hi folks, >> >> User is allowed to create custom cell but the valid code of type - >> KeyValue#Type - is declared as IA.Private. As i see it, we should expose >> KeyValue#Type as Public Client. Three possible ways are shown below: >> 1) Change declaration of KeyValue#Type from IA.Private to IA.Public >> 2) Move KeyValue#Type into Cell. >> 3) Move KeyValue#Type to upper level >> >> Any suggestions? >> >> -- >> Chia-Ping >> >>