Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D9A89200CE0 for ; Fri, 11 Aug 2017 08:12:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D826316CD60; Fri, 11 Aug 2017 06:12:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2ABAC16CD5B for ; Fri, 11 Aug 2017 08:12:04 +0200 (CEST) Received: (qmail 83964 invoked by uid 500); 11 Aug 2017 06:12:03 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 83946 invoked by uid 99); 11 Aug 2017 06:12:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 06:12:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 69B9EC05DC for ; Fri, 11 Aug 2017 06:12:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Mj2yySlLE4ME for ; Fri, 11 Aug 2017 06:12:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0AB0A5F613 for ; Fri, 11 Aug 2017 06:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 57ECBE07CF for ; Fri, 11 Aug 2017 06:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 11F5023FFD for ; Fri, 11 Aug 2017 06:12:00 +0000 (UTC) Date: Fri, 11 Aug 2017 06:12:00 +0000 (UTC) From: "Shibin Zhang (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-18568) Correct Regions metric of numRegions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 11 Aug 2017 06:12:05 -0000 Shibin Zhang created HBASE-18568: ------------------------------------ Summary: Correct Regions metric of numRegions Key: HBASE-18568 URL: https://issues.apache.org/jira/browse/HBASE-18568 Project: HBase Issue Type: Bug Components: metrics Affects Versions: 3.0.0 Reporter: Shibin Zhang Assignee: Shibin Zhang Priority: Critical i found the value of metric numReigons in Regions is not correct. the metric can not add or remove region correctly as region close or open. the metric as follow: "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions", "numRegions" : 2, after trouble shooting ,i found the reason is in MetricsRegionSourceImpl#MetricsRegionSourceImpl {code:java} agg.register(this); ... hashCode = regionWrapper.getRegionHashCode(); {code} when add the MetricsRegionSource to set ,but the hashCode has not yet initialized. So, the setFromMap can put or remove the object correctly. it will be better to move {code:java} hashCode = regionWrapper.getRegionHashCode(); {code} above {code:java} agg.register(this); {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)