Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 79545200497 for ; Wed, 23 Aug 2017 15:43:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 77E28168096; Wed, 23 Aug 2017 13:43:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF11D168095 for ; Wed, 23 Aug 2017 15:43:25 +0200 (CEST) Received: (qmail 78521 invoked by uid 500); 23 Aug 2017 13:43:23 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 78509 invoked by uid 99); 23 Aug 2017 13:43:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 13:43:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 85D2FC0042 for ; Wed, 23 Aug 2017 13:43:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mVyhJ-O14rb3 for ; Wed, 23 Aug 2017 13:43:21 +0000 (UTC) Received: from mail-yw0-f172.google.com (mail-yw0-f172.google.com [209.85.161.172]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 276865F46F for ; Wed, 23 Aug 2017 13:43:21 +0000 (UTC) Received: by mail-yw0-f172.google.com with SMTP id s143so1008742ywg.1 for ; Wed, 23 Aug 2017 06:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=7ZAfhSRHYouhXNF/qoAbdsvuA1UVqp1m261z+V0aECA=; b=YQJ73BSMwQrBh0cxdEYOAiP5Rv5fkP0YjnQMxaZ4YifbnKcLSXbo2JtKcZ6D5/Gzca vcVyLZlP3M7EjbSbozjzMQ+ob+bRVsilv6Z87mJxJ8amLwIFPF9Yri3uZehtrlFydBg4 iUyvz2hG390hpgjQZ5SOcljpH2G2T0UOCXzIm6Iya1Q2+HxHpiDeNldwl7tAhiOJ8PoE cASOcll+OqUGgbkYAvEuVpyP262GRNLTdsSbU7kzRzJn5N8bovRUSh1sHpda1P8FYYoI GcYE4psO8YA7zetB6e71WFvluAccK/8yQg2s+euIRP8ZJ/hudOYWr5kRSIruESAoBoyw PeYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=7ZAfhSRHYouhXNF/qoAbdsvuA1UVqp1m261z+V0aECA=; b=Q2Es2Mbjp/mMALO1/PsoBCCj/lynZd8W1t8Hf88eQ6YjbH/hbr/N5OASggxKvsWBo0 uSooRcyZ4MBqQynJnHmRraHTkBJ1f+RLoMYu4fBWg5GLPCn+L7EId0hAIEV1Mw6i8mNA gmqwZmdUdYRbDuCozkBVeaBKNe9gxkmFeUMfqFPw5vLNY/Yuav4LtjuntizGERrUf8oF v415oDxSi5JZAMSB9Wpfr/5ZnDOxpt1iH7XcqEdOwMZcr3PuAi6pg+F8rbi36CX8v39H wXlhFJMwX5X6b6A4bHNESU9zF3RaAzDmRIBZFuNjbKCUa4NxijeYS/A3/Eka5thyKRjh zHNg== X-Gm-Message-State: AHYfb5j0jP75egVJKtcnYzH1fWshkbIVvCUroacF5F5yp5nJm6WeNoyb 3sdT2CIlCEKol5xpLT7ocLIhBNuIJg== X-Received: by 10.37.54.34 with SMTP id d34mr2229765yba.115.1503495800522; Wed, 23 Aug 2017 06:43:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.192.193 with HTTP; Wed, 23 Aug 2017 06:43:20 -0700 (PDT) In-Reply-To: References: From: Ted Yu Date: Wed, 23 Aug 2017 06:43:20 -0700 Message-ID: Subject: Re: Different behavior in ScannerCallables To: "dev@hbase.apache.org" Content-Type: multipart/alternative; boundary="94eb2c1b20ec1c8f4d05576be532" archived-at: Wed, 23 Aug 2017 13:43:26 -0000 --94eb2c1b20ec1c8f4d05576be532 Content-Type: text/plain; charset="UTF-8" Please open a JIRA. On Wed, Aug 23, 2017 at 5:28 AM, Peter Somogyi wrote: > Hi, > > I noticed that the behavior of ReversedScannerCallable#prepare [1] > and ScannerCallable#prepare [2] methods differ how they > call RpcRetryingCallerWithReadReplicas.getRegionLocations method. > > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, > id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', so > I think the way we use it in ScannerCallable is the correct one. > > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > > Is it supposed to work like this? If not I can create a Jira and fix the > issue. > > Thanks, > Peter > > [1] > https://github.com/apache/hbase/blob/master/hbase- > client/src/main/java/org/apache/hadoop/hbase/client/ > ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase- > client/src/main/java/org/apache/hadoop/hbase/client/ > ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase- > client/src/main/java/org/apache/hadoop/hbase/client/ > ReversedScannerCallable.java#L143-L144 > --94eb2c1b20ec1c8f4d05576be532--