Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
MIME-Version: 1.0
In-Reply-To: <pony-51ef25fd0a3611d18ffb478ae2ae610bbbd2432c-73936ea1243ce2b7dd63b2a8434ad354eadaae3b@dev.hbase.apache.org>
References: <CAJL+TUTp2W4xx10aPJxAH5PK=p9Xa0VF6xfiZg0tVedS0NVsUg@mail.gmail.com>
 <pony-51ef25fd0a3611d18ffb478ae2ae610bbbd2432c-73936ea1243ce2b7dd63b2a8434ad354eadaae3b@dev.hbase.apache.org>
From: Lars George <lars.george@gmail.com>
Date: Sun, 6 Aug 2017 14:44:34 +0200
Message-ID: <CAJL+TUSSZyTLNBs9SU_fJadE_CcU1=fXY5ifOWTVvwj4LzVqOA@mail.gmail.com>
Subject: Re: Tags class using wrong length?
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Content-Type: text/plain; charset="UTF-8"
archived-at: Sun, 06 Aug 2017 12:44:45 -0000

You mean I am right and it should be the other constant being used?
Sorry, just wanting to confirm.


On Sun, Aug 6, 2017 at 2:40 PM, Chia-Ping Tsai <chia7712@apache.org> wrote:
> According to the following code:
>   public ArrayBackedTag(byte tagType, byte[] tag) {
>     int tagLength = tag.length + TYPE_LENGTH_SIZE;
>     if (tagLength > MAX_TAG_LENGTH) {
>       throw new IllegalArgumentException(
>           "Invalid tag data being passed. Its length can not exceed " + MAX_TAG_LENGTH);
>     }
>     length = TAG_LENGTH_SIZE + tagLength;
>     bytes = new byte[length];
>     int pos = Bytes.putAsShort(bytes, 0, tagLength);
>     pos = Bytes.putByte(bytes, pos, tagType);
>     Bytes.putBytes(bytes, pos, tag, 0, tag.length);
>     this.type = tagType;
>   }
> The layout of the byte array should be:
> |tag legnth (2 bytes)|tag type(1 byte)|tag|
>
> It seems to me that the "bytes[offset + TYPE_LENGTH_SIZE]" is correct.
>
> On 2017-08-06 16:35, Lars George <lars.george@gmail.com> wrote:
>> Hi,
>>
>> I found this reading through tags in 1.3, but checked in trunk as
>> well. There is this code:
>>
>>   public ArrayBackedTag(byte[] bytes, int offset, int length) {
>>     if (length > MAX_TAG_LENGTH) {
>>       throw new IllegalArgumentException(
>>           "Invalid tag data being passed. Its length can not exceed "
>> + MAX_TAG_LENGTH);
>>     }
>>     this.bytes = bytes;
>>     this.offset = offset;
>>     this.length = length;
>>     this.type = bytes[offset + TAG_LENGTH_SIZE];
>>   }
>>
>> I am concerned about the last line of the code, using the wrong constant?
>>
>>   public final static int TYPE_LENGTH_SIZE = Bytes.SIZEOF_BYTE;
>>   public final static int TAG_LENGTH_SIZE = Bytes.SIZEOF_SHORT;
>>
>> Should this not read
>>
>>     this.type = bytes[offset + TYPE_LENGTH_SIZE];
>>
>> Would this not read the type from the wrong place in the array?
>>
>> Cheers,
>> Lars
>>