hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-18572) Delete#addColumn can't remove the cell which has no visibility label
Date Fri, 11 Aug 2017 10:26:00 GMT
Chia-Ping Tsai created HBASE-18572:

             Summary: Delete#addColumn can't remove the cell which has no visibility label
                 Key: HBASE-18572
                 URL: https://issues.apache.org/jira/browse/HBASE-18572
             Project: HBase
          Issue Type: Bug
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai

  public boolean matchVisibility(List<Tag> putVisTags, Byte putTagsFormat, List<Tag>
      Byte deleteTagsFormat) throws IOException {
    if ((deleteTagsFormat != null && deleteTagsFormat == SORTED_ORDINAL_SERIALIZATION_FORMAT)
        && (putTagsFormat == null || putTagsFormat == SORTED_ORDINAL_SERIALIZATION_FORMAT))
      if (putVisTags.isEmpty()) {
        // Early out if there are no tags in the cell
        return false;
      if (putTagsFormat == null) {
        return matchUnSortedVisibilityTags(putVisTags, deleteVisTags);
      } else {
        return matchOrdinalSortedVisibilityTags(putVisTags, deleteVisTags);
    throw new IOException("Unexpected tag format passed for comparison, deleteTagsFormat :
        + deleteTagsFormat + ", putTagsFormat : " + putTagsFormat);
If the putVisTags is empty, it will return the false directly. Hence, the Delete#addColumn
can't "see" the cell as well as deleting it. The Delete#addColumns, by contrast, doesn't invoke
the cp#prePrepareTimeStampForDeleteVersion so it can remove the cell.

This message was sent by Atlassian JIRA

View raw message