hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Somogyi <psomo...@cloudera.com>
Subject Different behavior in ScannerCallables
Date Wed, 23 Aug 2017 12:28:43 GMT
Hi,

I noticed that the behavior of ReversedScannerCallable#prepare [1]
and ScannerCallable#prepare [2] methods differ how they
call RpcRetryingCallerWithReadReplicas.getRegionLocations method.

The reversed scanner uses the 'reload' parameter directly as the first
argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id,
getConnection(), getTableName(), getRow()) - however, the forward scanner
passes '!reload'. The getRegionLocations first parameter is 'useCache', so
I think the way we use it in ScannerCallable is the correct one.

The same call can be found in ReversedScannerCallable#locateRegionsInRange
[3] also without negating its value.

Is it supposed to work like this? If not I can create a Jira and fix the
issue.

Thanks,
Peter

[1]
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90
[2]
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140
[3]
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message