hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0
Date Mon, 28 Aug 2017 18:57:21 GMT
On Mon, Aug 28, 2017 at 4:05 AM, Yu Li <carp84@gmail.com> wrote:

> +1
>
> Checked sums and signatures: OK
> Build from source: OK, checked both "mvn clean install" and "mvn clean
> assembly:single", everything looks perfect
>
> Minor:
> 1. Also noticed the google directory after
> decompressing hbase-shaded-protobuf jar ball
> 2. Noticed patches-applied.txt in hbase-shaded-protobuf/target after build,
> maybe we could put the contents into CHANGES.txt?
>
> Thanks for voting Yu Li. Agree that we should note that the protobuf has
been patched. Let me do that for next release.
Thank you,
St.Ack





> Best Regards,
> Yu
>
> On 27 August 2017 at 14:43, 张铎(Duo Zhang) <palomino219@gmail.com> wrote:
>
> > +1 (binding)
> >
> > Checked sums and signatures: OK
> > 'mvn clean install': OK, the size of the generated jar files and sources
> > jar files are both reasonable
> > Unzip the generated jar files and sources jar files: OK, all
> > classes/sources are relocated under org/apache/hadoop/hbase/shaded.
> >
> > There are some proto files which are still under the 'google' directory
> and
> > the package in the proto files is not relocated, like this:
> >
> > option csharp_namespace = "Google.Protobuf.WellKnownTypes";
> > option go_package = "github.com/golang/protobuf/ptypes/any";
> > option java_package = "com.google.protobuf"; // <======== here
> > option java_outer_classname = "AnyProto";
> > option java_multiple_files = true;
> > option objc_class_prefix = "GPB";
> >
> > But I think this is OK as we will not use these protos file directly? And
> > anyway, The generated java files are relocated, I've already checked.
> >
> > Thanks.
> >
> > 2017-08-27 12:19 GMT+08:00 Stack <stack@duboce.net>:
> >
> > > Need a few pmc votes here please.  Just takes a minute.  Thanks in
> > advance.
> > > S
> > >
> > > On Aug 25, 2017 10:37, "Stack" <stack@duboce.net> wrote:
> > >
> > > > On Fri, Aug 25, 2017 at 10:06 AM, Mike Drob <mdrob@apache.org>
> wrote:
> > > >
> > > >> +1 (non-binding)
> > > >>
> > > >> Signatures and checksums good.
> > > >>
> > > >> LICENSE question... do we actually bundle jquery, asciidoctor, and
> the
> > > >> orca
> > > >> logo here? I didn't see them anywhere.
> > > >> CHANGES is mostly blank... If we don't use it, get rid of it in the
> > next
> > > >> version.
> > > >>
> > > >> Verified an hbase compile against this version, things looked ok.
> > Didn't
> > > >> run tests though.
> > > >>
> > > >>
> > > >
> > > > Thanks Mike (and Peter). Made HBASE-18684 to take care of the LICENSE
> > and
> > > > CHANGES files.
> > > >
> > > > St.Ack
> > > >
> > > >
> > > >
> > > >
> > > >> Mike
> > > >>
> > > >> On Thu, Aug 24, 2017 at 5:47 PM, Stack <stack@duboce.net> wrote:
> > > >>
> > > >> > +1 from me.
> > > >> >
> > > >> > On Wed, Aug 23, 2017 at 3:46 PM, Stack <stack@duboce.net>
wrote:
> > > >> >
> > > >> > > This is a minor update to hbase-thirdparty, our little side
> > project
> > > of
> > > >> > > relocated popular includes such as guava, protobuf, and
netty
> (See
> > > [1]
> > > >> > for
> > > >> > > more on what hbase-thirdparty is).
> > > >> > >
> > > >> > > hbase-thirdparty 1.0.1RC0 is available at:
> > > >> > >
> > > >> > >  https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdpart
> > > >> y/1.0.1RC0/
> > > >> > >
> > > >> > > Maven artifacts are available in the staging repository:
> > > >> > >
> > > >> > >  https://repository.apache.org/content/repositories/orgapache
> > > >> hbase-1174
> > > >> > >
> > > >> > > Artifacts are signed with 8ACC93D2 which is at the tail
of our
> > KEYS
> > > >> file
> > > >> > > http://www-us.apache.org/dist/hbase/KEYS.
> > > >> > >
> > > >> > > I tagged this RC as 1.0.1RC0 at in the hbase-thirdparty
repo at
> > > >> > > e07089bee6f51aec65de932b302894507903bd6e https://git-wip-
> > > >> > > us.apache.org/repos/asf/hbase-thirdparty
> > > >> > >
> > > >> > > This minor release includes three fixes:
> > > >> > >
> > > >> > > HBASE-18321 [hbase-thirdparty] Fix generation of
> > > >> META-INF/DEPENDENCIES to
> > > >> > > include dependency list and versions
> > > >> > > HBASE-18666 [hbase-thirdparty] Exclude errorprone annotation
> > > >> > > com.google.errorprone.annotations.CanIgnoreReturnValue
> > > >> > > HBASE-18313 [hbase-thirdparty] Produce src jars/tgz
> > > >> > >
> > > >> > > The first fixes an issue found during VOTE on 1.0.0, the
second
> > > makes
> > > >> it
> > > >> > > so errorprone build will work back in mainline hbase, and
the
> > third
> > > >> has
> > > >> > us
> > > >> > > producing src jars when we publish to maven.
> > > >> > >
> > > >> > > VOTE lasts 72 hours.
> > > >> > >
> > > >> > > Thanks,
> > > >> > > St.Ack
> > > >> > >
> > > >> > >
> > > >> > > 1. http://hbase.apache.org/book.html#thirdparty
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message