hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-18473) VC.listLabels() erroneously closes any connection
Date Fri, 28 Jul 2017 18:30:00 GMT
Lars George created HBASE-18473:
-----------------------------------

             Summary: VC.listLabels() erroneously closes any connection
                 Key: HBASE-18473
                 URL: https://issues.apache.org/jira/browse/HBASE-18473
             Project: HBase
          Issue Type: Bug
          Components: Client
    Affects Versions: 1.1.11, 1.2.6, 1.3.1
            Reporter: Lars George


In HBASE-13358 the {{VisibilityClient.listLabels()}} was amended to take in a connection from
the caller, which totally makes sense. But the patch forgot to remove the unconditional call
to {{connection.close()}} in the {{finally}} block:

{code}
    finally {
      if (table != null) {
        table.close();
      }
      if (connection != null) {
        connection.close();
      }
    }
{code}

Remove the second {{if}} completely.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message