Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C6B32200C7D for ; Tue, 16 May 2017 16:01:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C542D160BCF; Tue, 16 May 2017 14:01:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 187AB160B9D for ; Tue, 16 May 2017 16:01:07 +0200 (CEST) Received: (qmail 60896 invoked by uid 500); 16 May 2017 14:01:07 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 60885 invoked by uid 99); 16 May 2017 14:01:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 14:01:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A95BBD00A8 for ; Tue, 16 May 2017 14:01:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id p6M8MC6TO2xS for ; Tue, 16 May 2017 14:01:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D84FB5FE0B for ; Tue, 16 May 2017 14:01:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2812AE0B4A for ; Tue, 16 May 2017 14:01:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 74A8321941 for ; Tue, 16 May 2017 14:01:04 +0000 (UTC) Date: Tue, 16 May 2017 14:01:04 +0000 (UTC) From: "Duo Zhang (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-18059) The scanner order for memstore scanners are wrong MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 16 May 2017 14:01:09 -0000 Duo Zhang created HBASE-18059: --------------------------------- Summary: The scanner order for memstore scanners are wrong Key: HBASE-18059 URL: https://issues.apache.org/jira/browse/HBASE-18059 Project: HBase Issue Type: Bug Components: regionserver, scan, Scanners Affects Versions: 2.0.0 Reporter: Duo Zhang Fix For: 2.0.0 This is comments for KeyValueScanner.getScannerOrder {code:title=KeyValueScanner.java} /** * Get the order of this KeyValueScanner. This is only relevant for StoreFileScanners and * MemStoreScanners (other scanners simply return 0). This is required for comparing multiple * files to find out which one has the latest data. StoreFileScanners are ordered from 0 * (oldest) to newest in increasing order. MemStoreScanner gets LONG.max since it always * contains freshest data. */ long getScannerOrder(); {code} As now we may have multiple memstore scanners, I think the right way to select scanner order for memstore scanner is to ordered from Long.MAX_VALUE in decreasing order. But in CompactingMemStore and DefaultMemStore, the scanner order for memstore scanner is also start from 0, which will be messed up with StoreFileScanners. -- This message was sent by Atlassian JIRA (v6.3.15#6346)