Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DE159200C68 for ; Wed, 3 May 2017 23:11:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DCACE160BBA; Wed, 3 May 2017 21:11:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 31A7F160BA1 for ; Wed, 3 May 2017 23:11:08 +0200 (CEST) Received: (qmail 20581 invoked by uid 500); 3 May 2017 21:11:07 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 20558 invoked by uid 99); 3 May 2017 21:11:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 21:11:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 915261A01F4 for ; Wed, 3 May 2017 21:11:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vb1hqyR3rRRY for ; Wed, 3 May 2017 21:11:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 93E715FE2D for ; Wed, 3 May 2017 21:11:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 057F4E0D5F for ; Wed, 3 May 2017 21:11:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 58A5B21DF2 for ; Wed, 3 May 2017 21:11:04 +0000 (UTC) Date: Wed, 3 May 2017 21:11:04 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 03 May 2017 21:11:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-12870. ------------------------------------ Resolution: Fixed +1 Committed addendum > "Major compaction triggered" and "Skipping major compaction" messages lack the region information > ------------------------------------------------------------------------------------------------- > > Key: HBASE-12870 > URL: https://issues.apache.org/jira/browse/HBASE-12870 > Project: HBase > Issue Type: Improvement > Components: Compaction > Affects Versions: 1.3.1 > Reporter: Hari Krishna Dara > Assignee: Chinmay Kulkarni > Labels: compaction, patch > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-12870_addendum.patch, HBASE-12870.patch > > > The below messages coming from {{RatioBasedCompactionPolicy}} log the default {{.toString()}} output of itself, which is not useful: > {noformat} > 2015-01-16 06:15:07,166 DEBUG org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy: Major compaction triggered on store org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5; time since last major compaction 339994249ms > {noformat} > {noformat} > 2015-01-16 09:49:12,872 DEBUG org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy: Skipping major compaction of org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb because one (major) compacted file only and oldestTime 6795587394ms is < ttl=15552000000 > {noformat} > It should log the store/region information instead. Unfortunately, this information seems to be unavailable at this point, so more context needs to be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)