Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E67D0200C88 for ; Fri, 19 May 2017 01:32:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E4E7D160BC4; Thu, 18 May 2017 23:32:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 352B3160BB5 for ; Fri, 19 May 2017 01:32:56 +0200 (CEST) Received: (qmail 74121 invoked by uid 500); 18 May 2017 23:32:55 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 74105 invoked by uid 99); 18 May 2017 23:32:53 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 May 2017 23:32:53 +0000 Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 928861A0280 for ; Thu, 18 May 2017 23:32:53 +0000 (UTC) Received: by mail-it0-f53.google.com with SMTP id e65so37768433ita.1 for ; Thu, 18 May 2017 16:32:53 -0700 (PDT) X-Gm-Message-State: AODbwcDZKOKsynnMn56qj3OB4t/GqE1iaAVV25bRR8JrdjZh/Niyvj+p yZEfXqkBWrT6qy7dygngq2JLbVsFWA== X-Received: by 10.36.127.200 with SMTP id r191mr7583945itc.91.1495150373002; Thu, 18 May 2017 16:32:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.8.158 with HTTP; Thu, 18 May 2017 16:32:32 -0700 (PDT) In-Reply-To: <5914DC92.3030904@apache.org> References: <590D0995.1030205@apache.org> <5914DC92.3030904@apache.org> From: =?UTF-8?Q?Enis_S=C3=B6ztutar?= Date: Thu, 18 May 2017 16:32:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [VOTE] Merge space quota branch (HBASE-16961) into master To: "dev@hbase.apache.org" Content-Type: multipart/alternative; boundary="001a1147c91ede6aa2054fd4d26e" archived-at: Thu, 18 May 2017 23:32:57 -0000 --001a1147c91ede6aa2054fd4d26e Content-Type: text/plain; charset="UTF-8" Sorry missed the deadline again, but I've spend some time with the patches today, and I'll cast my vote as +1 for the merge. This feature is pretty relevant to multi-tenant, bigger clusters, and is a good complimentary to existing quotas support. - The code is high quality, readable, pluggable and comes with a large number of unit tests. - Comes with shell support, Master UI, and metrics - Documentation Ideally, we can have this in 2.0 (even without HBASE-17748 ), because it is useable at this point. From my reading of the code, there is no risk to destabilizing the current code base since almost all of the code is new, and disabled by default. Thanks, Enis On Thu, May 11, 2017 at 2:50 PM, Josh Elser wrote: > As requested (later in this thread), I'll make sure this VOTE stays open > at least until 2017-05-17 (an extra week). If time continues to be a > barrier for review/input, please do speak up. > > > Josh Elser wrote: > >> Folks, >> >> This is a vote to (rebase and) merge the branch HBASE-16961 into master. >> Per the book, this requires 3 binding +1's from other committers to merge. >> >> Relevant info for those who want to revisit any topics: >> >> DISCUSS on merge[1] >> Design Doc[2] >> Staged user manual[3] >> >> I'll plan to leave this open for at least 72hrs of the work days >> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to >> abstain from voting on my own feature and plan to do so if the votes are >> otherwise lacking. >> >> - Josh >> >> [1] >> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94 >> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E >> >> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac >> heHBase.pdf >> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas >> > --001a1147c91ede6aa2054fd4d26e--