hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Allen Wittenauer ...@effectivemachines.com>
Subject Re: Sporadically failing precommit tasks
Date Tue, 02 May 2017 18:53:31 GMT

Hmmm.  It's an interesting side-effect of how docker caches intermediate images:

===

Step 10/35 : RUN apt-get -q update
 ---> Using cache
 ---> 79fd4a487c35
Step 11/35 : RUN echo oracle-java7-installer shared/accepted-oracle-license-v1-1 select true
| sudo /usr/bin/debconf-set-selections
 ---> Using cache
 ---> 516879ab5193
Step 12/35 : RUN apt-get -q install -y oracle-java7-installer
 ---> Using cache
 ---> c3c88064dbd7
Step 13/35 : RUN echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true
| sudo /usr/bin/debconf-set-selections
 ---> Using cache
 ---> 98013d157fba
Step 14/35 : RUN apt-get -q install --no-install-recommends -y oracle-java8-installer

===

Step 10 should probably get merged into Step 12 and Step 14 then re-arranged a bit.  e.g.,

===
RUN echo oracle-java7-installer shared/accepted-oracle-license-v1-1 select true | sudo /usr/bin/debconf-set-selections
RUN echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | sudo /usr/bin/debconf-set-selections
RUN apt-get -q update && apt-get -q install -y oracle-java7-installer
RUN apt-get -q update && apt-get -q install --no-install-recommends -y oracle-java8-installer
===

This would force the update and the image pull to be cached into the same intermediate.

Although I've been thinking more and more that at least for the default Yetus Dockerfile,
we should probably switch to OpenJDK entirely.  
Mime
View raw message