Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Date: Tue, 4 Apr 2017 10:12:42 +0000 (UTC)
From: "Chia-Ping Tsai (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.13061398.1491300742000.199681.1491300762755@Atlassian.JIRA>
In-Reply-To: <JIRA.13061398.1491300742000@Atlassian.JIRA>
References: <JIRA.13061398.1491300742000@Atlassian.JIRA> <JIRA.13061398.1491300742290@jira-lw-us.apache.org>
Subject: [jira] [Created] (HBASE-17872) Make ByteBufferUtils thread-safe
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 04 Apr 2017 10:12:50 -0000

Chia-Ping Tsai created HBASE-17872:
--------------------------------------

             Summary: Make ByteBufferUtils thread-safe
                 Key: HBASE-17872
                 URL: https://issues.apache.org/jira/browse/HBASE-17872
             Project: HBase
          Issue Type: Bug
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai
            Priority: Critical


A case is shown below.
We will get the wrong position of buffer in multithreaded environment, so the method makes the invalid cell in MSLAB.
{noformat}
  public static int copyFromBufferToBuffer(ByteBuffer in, ByteBuffer out, int sourceOffset,
      int destinationOffset, int length) {
    if (in.hasArray() && out.hasArray()) {
      // ...
    } else if (UNSAFE_AVAIL) {
      // ...
    } else {
      int outOldPos = out.position();
      out.position(destinationOffset);
      ByteBuffer inDup = in.duplicate();
      inDup.position(sourceOffset).limit(sourceOffset + length);
      out.put(inDup);
      out.position(outOldPos);
    }
    return destinationOffset + length;
  }
{noformat}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)