hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-10540) HBaseAdmin.createTable(HTableDescriptor, splitKeys) doesn't need to call isLegalTableName.
Date Sat, 29 Apr 2017 02:09:04 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chia-Ping Tsai resolved HBASE-10540.
------------------------------------
    Resolution: Won't Fix

The isLegalTableName has removed by HBASE-8408. 0.94 is EOL.

> HBaseAdmin.createTable(HTableDescriptor, splitKeys) doesn't need to call isLegalTableName.
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10540
>                 URL: https://issues.apache.org/jira/browse/HBASE-10540
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.16
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>         Attachments: HBASE-10540-v0-0.94.patch
>
>
> {code}
> public void createTable(final HTableDescriptor desc, byte [][] splitKeys)
>   throws IOException {
>     HTableDescriptor.isLegalTableName(desc.getName());
>     try {
>       createTableAsync(desc, splitKeys);
>     } catch (SocketTimeoutException ste) {
>       LOG.warn("Creating " + desc.getNameAsString() + " took too long", ste);
>     }
> {code}
> crateTable calls isLegalTableName and few lines after, createTableAsync. However, createTableAsync
also calls isLegalTableName which results to a double call.
> Therefor, we can remove the call to isLegalTableName from crateTable.
> Trunk does'nt call isLegalTableName (Should it?).  Nor is 0.96.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message