Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
From: Andrew Purtell <andrew.purtell@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Thu, 23 Mar 2017 15:29:43 -0700
Subject: Re: [DISCUSS] Moving towards merge on HBASE-16961 (space quota)
Message-Id: <CE1310C8-4435-4855-B0CE-2E4D90305C92@gmail.com>
References: <58D0496E.4060101@apache.org> <58D05CF4.7050705@apache.org> <58D409AA.40701@apache.org>
In-Reply-To: <58D409AA.40701@apache.org>
To: dev@hbase.apache.org
archived-at: Thu, 23 Mar 2017 22:29:53 -0000

Hi Josh,

I will have some time soon to look at this. Definitely of interest.=20

I may look at it as a process of a port to a branch-1 like code base. Helps t=
hat all of the work is on a branch.=20

One thing that would be helpful, maybe in javadoc of an integration test or i=
n the release notes, or on the umbrella JIRA, would be a step by step exampl=
e of application and verification of a simple space quota, say by namespace.=
 If this already exists a pointer would be helpful. To start I'd want to run=
 through something expected to work.=20


> On Mar 23, 2017, at 10:45 AM, Josh Elser <elserj@apache.org> wrote:
>=20
> bump
>=20
> Josh Elser wrote:
>> Rebase is done for those who want to just look at some code.
>>=20
>> https://github.com/apache/hbase/compare/HBASE-16961
>>=20
>> Josh Elser wrote:
>>> Hiya folks,
>>>=20
>>> As advertised (warned? *winks*), all of the sub-tasks on HBASE-16961
>>> have been resolved after being committed to the HBASE-16961 branch in
>>> SCM.
>>>=20
>>> While Ted has been a stalwart reviewer, it would be good to get another
>>> set of eyes (or a few sets) on the changes before considering I start a
>>> vote to merge into master.
>>>=20
>>> Presently, I'm rebasing the branch on top of master (as it's been a
>>> while since I've done that). While I do that, I wanted to ask: what can
>>> I do to help make this review process easiest?
>>>=20
>>> * Squash commits into one and put on RB?
>>> * Pointers to tests that outline how users interact via API?
>>> * Put together a little example devs can work through locally?
>>>=20
>>> I want to avoid this work lingering in the ether for a long period of
>>> time -- I'm happy to try to make what will surely be a difficult review
>>> any easier.
>>>=20
>>> - Josh