Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 04A57200C1B for ; Tue, 14 Feb 2017 11:13:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 03456160B6A; Tue, 14 Feb 2017 10:13:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 53661160B5F for ; Tue, 14 Feb 2017 11:13:45 +0100 (CET) Received: (qmail 52650 invoked by uid 500); 14 Feb 2017 10:13:44 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 52629 invoked by uid 99); 14 Feb 2017 10:13:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2017 10:13:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E8E4D188004 for ; Tue, 14 Feb 2017 10:13:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id pkrxhJkR5X17 for ; Tue, 14 Feb 2017 10:13:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BC6D65F659 for ; Tue, 14 Feb 2017 10:13:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EFBE1E0059 for ; Tue, 14 Feb 2017 10:13:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AC7592411B for ; Tue, 14 Feb 2017 10:13:41 +0000 (UTC) Date: Tue, 14 Feb 2017 10:13:41 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-17647) OffheapKeyValue#heapSize() implementation is wrong MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 14 Feb 2017 10:13:46 -0000 Anoop Sam John created HBASE-17647: -------------------------------------- Summary: OffheapKeyValue#heapSize() implementation is wrong Key: HBASE-17647 URL: https://issues.apache.org/jira/browse/HBASE-17647 Project: HBase Issue Type: Sub-task Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0 We consider the key and data lengths also even though the data is actually in off heap area. We should correct it. The impact will be at ScannerContext limit tracking where we use heapSize of cells to account the result size. So my proposal is to consider the cells length and heap size in Limit tracking and accounting. We have a maxResultSize which defaults to 2MB. When the sum of all cell's data size reaches 'maxResultSize' OR the sum of all cell's heap size reaches 'maxResultSize' , we need to send back the RPC response -- This message was sent by Atlassian JIRA (v6.3.15#6346)